Skip to content

Compact the differential safety snapshot - #2472

Merged
BigSimmo merged 9 commits into
mainfrom
codex/compact-differential-safety-note-20260830
Aug 31, 2026
Merged

Compact the differential safety snapshot#2472
BigSimmo merged 9 commits into
mainfrom
codex/compact-differential-safety-note-20260830

Conversation

@BigSimmo

@BigSimmo BigSimmo commented Aug 31, 2026

Copy link
Copy Markdown
Owner

Summary

  • Compact the shared differential Safety Snapshot header, spacing, typography, icon treatment, watch list, and metrics so the clinical note occupies substantially less vertical space.
  • Remove the redundant "Review must-not-miss causes" action while retaining the safety content.
  • Keep all available safety metrics, including four-item records, on one row and cover the phone layout, accessibility labels, reduced motion, and forced-colors behavior.

Verification

  • npm run verify:pr-local — passed: runtime and lock parity, changed-file formatting, lint, typecheck, 930 test files / 11,660 tests, repo-awareness, production build (1,998 static pages), client-secret scan, 36 RAG golden cases / 26 suites, and medication data checks.

During development, use npm run verify:cheap as the faster iteration gate before the final PR-local preflight.

  • npm run verify:ui when UI, routing, styling, browser behavior, reduced-motion, or forced-colors behavior changed
  • npm run verify:release before release or handoff confidence claims

UI verification not run: the broad UI suite was not repeated because shared UI foundations did not change. The focused Chromium journey in tests/ui-tools.spec.ts passed 1/1 and checks 320px phone and 1024px desktop/tablet behavior, no horizontal page overflow, four metrics on one row, the compact card height, removal of the old action, reduced motion, and forced colors.

For retrieval, ranking, selection, chunking, source/citation rendering, or answer-contract changes, verify:pr-local runs eval:rag:offline automatically. Run the offline command directly during iteration before spending a live eval.

  • npm run eval:retrieval:quality (must stay 36/36) when retrieval, ranking, selection, chunking, or scoring behavior changed — not applicable; retrieval behavior is unchanged.
  • npm run eval:rag -- --limit 15 + npm run eval:quality -- --rag-only when answer generation, the synthesis prompt, or answer post-processing changed — not applicable; answer generation is unchanged.
  • npm run check:production-readiness when clinical workflow, privacy, environment, Supabase, source governance, or deployment behavior changed — not applicable; this is a presentation-only change.
  • npm run check:deployment-readiness when deployment startup, hosting, or rollout behavior changed — not applicable.

Risk and rollout

  • Risk: Low and bounded to differential-detail presentation. Safety content and counts remain intact; compact visual metric labels retain full accessible names. Long watch items stay on one horizontal row and may scroll within the card on narrow phones.
  • Rollback: Revert commit c677e3e0ddc93fbe31d77b068843343a094e11c3.
  • Provider or production effects: None. No provider calls, hosted data writes, migrations, or deployment changes.
  • RAG impact: none; retrieval, ranking, sources, citations, and answer behavior are unchanged.

Clinical Governance Preflight

  • Source-backed claims still require linked source verification before clinical use
  • No patient-identifiable document workflow was introduced or expanded without explicit governance approval
  • Supabase target remains Clinical KB Database (sjrfecxgysukkwxsowpy)
  • Service-role keys and private document access remain server-only
  • Demo/synthetic content remains clearly separated from real clinical sources
  • Source metadata, review status, and outdated/unknown-source behavior remain conservative
  • Deployment classification/TGA SaMD impact was checked when clinical decision-support behavior changed

Notes

  • npm run format and npm run design-system:adoption:update left the branch unchanged.
  • The first full-suite attempt exposed Windows resolving bash to WSL for an unchanged current-main test. Prefixing Git Bash on the test process PATH made the focused file pass 24/24; the final full gate passed.
  • A stale ignored .next/dev/types/validator.ts initially blocked the build. Route types were regenerated, the stale ignored artifact was removed, and the final production build passed without tracked changes.

Co-Authored-By: Codex Fable 5 noreply@anthropic.com


Note

Low Risk
Presentation-only changes on the differential detail overview; clinical safety data and counts are unchanged, with full metric labels still exposed via aria-label.

Overview
Compacts the differential overview Safety Snapshot so it uses less vertical space while keeping the same safety content (summary, watch-for tags, and metric counts).

The card gets tighter padding and smaller header/typography, drops the inline status badge and the Review must-not-miss causes button (along with scroll-to-section behavior and resolveScrollBehavior). Watch-for chips move to a single horizontal row with in-card scrolling on narrow widths. Four safety metrics stay on one row via grid-cols-4, with smaller mobile metric text and data-testid hooks for values and the watchlist.

Tests extend unit checks for the compact grid and removed CTA, and Playwright at 320px asserts one metric row, no CTA, bounded card height, no horizontal overflow, and stable layout under reduced motion and forced colors.

Reviewed by Cursor Bugbot for commit 714785b. Configure here.

Co-Authored-By: Codex Fable 5 <noreply@anthropic.com>
@supabase

supabase Bot commented Aug 31, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-31T02:23:36.180002Z c677e3e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: ea960795-9960-4b74-8a53-2033170f3172


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cursor

cursor Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_744b4e06-7248-4710-8be5-03182d1a58ed)

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c677e3e0dd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/components/differentials/differential-detail-page.tsx
@BigSimmo
BigSimmo enabled auto-merge (squash) August 31, 2026 03:16
@cursor

cursor Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_2c07dab3-819d-43b8-b966-8e3ab13b0299)

@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

CI triage

CI failed on this PR. Automated classification of the 2 failed job(s):

  • Production UI (1)not baselined: this job did NOT run on the main comparison below (path-scoped skip), so that run says nothing about it either way. Treat the comparison as absent, not green, and inspect the failing step.
  • PR requiredneeds investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.

Compared with main CI run #14542 (success). That run's conclusion is an aggregate and did not exercise Production UI (1).

Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger.

@BigSimmo
BigSimmo merged commit 779efa2 into main Aug 31, 2026
28 of 29 checks passed
@BigSimmo
BigSimmo deleted the codex/compact-differential-safety-note-20260830 branch August 31, 2026 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant