Remove redundant feasibility checks from hot prediction paths - #235
Open
Alexander-Mitrofanov wants to merge 3 commits into
Open
Remove redundant feasibility checks from hot prediction paths#235Alexander-Mitrofanov wants to merge 3 commits into
Alexander-Mitrofanov wants to merge 3 commits into
Conversation
martin-raden
requested changes
Aug 16, 2026
martin-raden
left a comment
Member
There was a problem hiding this comment.
I have checked and approved all changes.
- TODO: update "Changelog" file accordingly
and this will be ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements AP-1, the first measured phase-3 optimization from discussion #232, on the current C++23 base.
areComplementary()already enforces nucleotide complementarity and both accessibility predicates. This change removes duplicate direct accessibility checks from hot predictor and seed paths while preserving the existing row-level screens, recurrence traversal, arithmetic, candidate ordering, and accepted base pairs. A focused counting regression proves the default no-bulge seed path no longer repeats those calls.The originally reviewed source/test change remains byte-identical to commit
56ac5eb. Commitfd55acbintegrates the current C++23 base without conflicts, and0a5cb8aadds theChangeLogentry requested in review.Validation
902236560b48e0aa27166b0be42a0bea8e2624420a5cb8a0aade74d18e901f3b0f48cf1627800f76fd55acb3.493944 +/- 0.015863 sto3.454898 +/- 0.014861 s(1.011x)0.750087 +/- 0.011438 sto0.692586 +/- 0.003439 s(1.083x)Batch
ap1-current-cpp23-base-20260826uses parent/candidate benchmark IDsc3a4d4509048019964d420c732cfecf116597eaa1d6944a8db83c3a9e0074e44and119aaba30a7e6b51d46f2f4b982bc3de1a1c728cf87a689058a8562f3f7120df.The schema-validated JSON, compressed outputs, and generated report are in benchmark evidence commit
392147cand benchmark PR #3. The older8bd1676 -> 56ac5ebmeasurements remain historical evidence and are superseded for acceptance by this current-base batch.The refreshed C/C++ CI run is green on the exact candidate head: GCC 14 release, GCC 14 debug, and Apple Clang/libc++ release each pass build, install, the complete test suite, independent compilation of every installed public header, and an installed pkg-config consumer. The benchmark repository's validation run is also green.