Modernize IntaRNA with focused C++23 facilities - #234
Open
Alexander-Mitrofanov wants to merge 23 commits into
Open
Modernize IntaRNA with focused C++23 facilities#234Alexander-Mitrofanov wants to merge 23 commits into
Alexander-Mitrofanov wants to merge 23 commits into
Conversation
martin-raden
requested changes
Aug 16, 2026
martin-raden
left a comment
Member
There was a problem hiding this comment.
I have checked and approved all changes.
- TODO: update "Changelog" file accordingly
and this will be ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements phase 2 of discussion #232 as a focused, scientifically neutral C++23 modernization.
What changed
string::contains,string::resize_and_overwrite, andbasic_stringstream::view-pedantic-errors, while treating supported Boost/ViennaRNA paths as system headersresize_and_overwriteand inserts completed output through non-owning stream viewsChangeLogScientific scope
Predictor recurrences, energy models, coordinate conventions, partition definitions, arithmetic order, OpenMP topology, CLI behavior, and output schemas are unchanged. The modernization deliberately excludes modules,
mdspan,format/print, parallel ranges, matrix-layout changes, and recurrence rewrites because they are either unavailable across both required standard libraries or belong in separately benchmarked performance phases.No implementation code was imported from alternate IntaRNA trees.
Validation
321364c56e914e9eff56ddba4846852297fe5c557a9517b0587dd308659b61f81b26373ac7a5d0b5The raw JSON, compressed outputs, and generated report are in benchmark evidence commit
69174eband benchmark PR #2. The full decision/evidence record is indoc/refactor/2-c++23.md.The actual head passed both triggered copies of the required matrix: pull-request run
32979758447and push run32979767757. Each passed GCC 14 release, GCC 14 debug, and Apple Clang/libc++ release, including build, full tests, install, 65 public-header probes, and the installed pkg-config consumer. Phase 1 scientific corrections remain in #233.