[bugfix] Fix flashlight slider flicker at minimum brightness - #62
Open
varakumar01 wants to merge 1 commit into
Open
[bugfix] Fix flashlight slider flicker at minimum brightness#62varakumar01 wants to merge 1 commit into
varakumar01 wants to merge 1 commit into
Conversation
… flashlight slider all the way down to the bottom Signed-off-by: Varakumar <varakumar7000@gmail.com>
varakumar01
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the flicker/flash that happens when dragging the QS flashlight slider all the way down to the bottom.
What was wrong:
The fade-out animation always started from full brightness instead of the level the torch was actually at. So dragging down to a low level and letting go made the LED jump back up to full brightness for a moment before fading off. Holding your finger at the bottom made this repeat over and over, which looked like flickering.
Fix: