feat(display): per-output ICC color profiles and color temperature - #3388
Open
KIDult2226 wants to merge 7 commits into
Open
feat(display): per-output ICC color profiles and color temperature#3388KIDult2226 wants to merge 7 commits into
KIDult2226 wants to merge 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds per-output ICC color profile support and per-output color temperature to the night light / gamma stack.
ICC profiles
core/internal/iccpackage: ICC v2/v4 parser (TRC curves, LUT8/LUT16 and parametric curves,vcgt, description/version/color space metadata) with unit tests.iccProfilesfrom the night light config (~/.config/niri/dms/wayland.json), builds gamma ramps from the parsed profile per output, falls back to temperature ramps when a profile is missing or unparsable, and re-applies on output hotplug and after resume.Per-output temperature
outputTempsin the same config;SetOutputTempaccepts 1000-10000K and the Display Config slider exposes the full 3000-10000K range, which matters for displays calibrated at a higher white point (e.g. a 7000K-calibrated ICC profile).IPC / CLI
wayland.icc.getStatus,wayland.icc.apply,wayland.icc.remove,wayland.icc.listOutputs,wayland.icc.setTemp,wayland.icc.getTemps.dms icc list | info <file> | apply <output> <file> | remove <output> | status.UI
quickshell/Services/ICCService.qml.Included fix
LoadConfig()now takes its fallback values fromDefaultConfig()and coversContrast.Validate()rejectsContrast == 0, so night light configs written before that field existed aborted manager construction and took gamma/ICC down entirely (wayland manager not initialized).Type of change
Related issues
Screenshots / video
Display Config output cards with the new Color Profile row (browse / apply / remove, showing an applied profile with version, color space and active state) and the per-output Color Temp slider set to 7000K on the calibrated display:
Checklist
I18n.tr()with translator context, reusing existing terms where possiblemake fmt, added/updated tests,make testpasses (TZ=UTC go test ./...-> 51 ok, 0 fail), andgo mod tidyis cleanmake lint-qmlwith no new warnings