fix: template literal OOM error caused by child elements not visible to GC in staticArray - #3039
Open
KKiiim wants to merge 1 commit into
Open
fix: template literal OOM error caused by child elements not visible to GC in staticArray#3039KKiiim wants to merge 1 commit into
KKiiim wants to merge 1 commit into
Conversation
KKiiim
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause:
When AssemblyScript compiles a template literal for string concatenation, the compiler generates a static
StaticArray<string>as an intermediate buffer. This static array resides in the data segment with its ITCMS GC headergcInfoset to3(transparent/pinned color), but the object is neither linked into the pinSpace linked list nor visited by__visit_globals(which explicitly skips static GC objects). As a result, the GC has no way to trace the dynamic child strings written into the array via__uset, and may incorrectly collect strings that are still in use — leading tortSizecorruption, memory corruption, and eventual trap crashes.