Skip to content

Allow x and z manual movement - #157

Open
micahwoodard wants to merge 1 commit into
mainfrom
fix-manual-stage-movement
Open

Allow x and z manual movement#157
micahwoodard wants to merge 1 commit into
mainfrom
fix-manual-stage-movement

Conversation

@micahwoodard

@micahwoodard micahwoodard commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

Allows x and z movements within session. Y movement will still be reset. Also adds final stage position.

Partially addressing concerns in #170 and #142

@alexpiet

Copy link
Copy Markdown
Collaborator

To clarify the behavior:

  • manual movements in X and Z are preserved (not reset)
  • the anti-bias algorithm works relative to the initial position in X + any manual movements
  • Movements in Y are reset at the start of the next trial
  • If a user decides the Y position is poor, either too close or too far from the mouse, then they would need to stop the session to modify the position.

@alexpiet

Copy link
Copy Markdown
Collaborator

Does the PR additional start the session using the final position from the previous session? Or simply just record the final position? Its hard to read the bonsai code changes on github

@bruno-f-cruz bruno-f-cruz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I dont think we can implement the logic like this (also the reason why I did not want to implement it in the first place :P).

I still think it is super dangerous to allow people to save a new position mid-session. What if someone closes the session while the spout is retracted? What if the spout is midway through travel? Too many edge cases. If you want to do this, you gotta figure out a way to log the position of the spout during a period where NO manual intervention is allowed, and you are absolutely sure the spout is in the extended position.

@alexpiet

Copy link
Copy Markdown
Collaborator

The current behavior allows the movement, but then (inconsistently) resets it.

I think we either need to not allow any manual movement at all, even temporarily, or allow movement in X and Z.

@micahwoodard

Copy link
Copy Markdown
Collaborator Author

Does the PR additional start the session using the final position from the previous session? Or simply just record the final position? Its hard to read the bonsai code changes on github

It logs the final position but pushing for next session will be handled by micestro in a separate pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants