Allow x and z manual movement - #157
Conversation
|
To clarify the behavior:
|
|
Does the PR additional start the session using the final position from the previous session? Or simply just record the final position? Its hard to read the bonsai code changes on github |
bruno-f-cruz
left a comment
There was a problem hiding this comment.
I dont think we can implement the logic like this (also the reason why I did not want to implement it in the first place :P).
I still think it is super dangerous to allow people to save a new position mid-session. What if someone closes the session while the spout is retracted? What if the spout is midway through travel? Too many edge cases. If you want to do this, you gotta figure out a way to log the position of the spout during a period where NO manual intervention is allowed, and you are absolutely sure the spout is in the extended position.
|
The current behavior allows the movement, but then (inconsistently) resets it. I think we either need to not allow any manual movement at all, even temporarily, or allow movement in X and Z. |
It logs the final position but pushing for next session will be handled by micestro in a separate pr |
Allows x and z movements within session. Y movement will still be reset. Also adds final stage position.
Partially addressing concerns in #170 and #142