Skip to content

[PWGLF] gate histogram creation to reduce memory consumption - #17563

Merged
mpuccio merged 1 commit into
AliceO2Group:masterfrom
GiorgioAlbertoLucia:li4
Aug 22, 2026
Merged

[PWGLF] gate histogram creation to reduce memory consumption#17563
mpuccio merged 1 commit into
AliceO2Group:masterfrom
GiorgioAlbertoLucia:li4

Conversation

@GiorgioAlbertoLucia

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 9 errors, ⚠️ 7 warnings, 🔕 0 disabled

@alibuild

alibuild commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 441474a at 2026-08-22 21:16:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 30 errors and 6 warnings.'
Found 30 errors and 6 warnings.
++ [[ 30 -gt 0 ]]
++ cat /sw/BUILD/0eabc695084d3a5b9b6a4dbec868e3b1f1049b02/O2Physics-code-check/errors.txt
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:95:22: error: variable 'hEvtMC' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:96:22: error: variable 'hImpactParamGen' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:97:22: error: variable 'hImpactParamReco' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:98:22: error: variable 'hRecoCentrality' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:99:22: error: variable 'hImpactParamGenOneReco' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:100:22: error: variable 'hGenOneRecoCentrality' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:101:17: error: no header providing "TH2" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:101:22: error: variable 'hGenEventsNchEta05' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:102:22: error: variable 'hGenEventsNchEta08' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:103:22: error: variable 'hRecoCentralityColvsMultiplicityRecoEta05' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:104:22: error: variable 'hRecoCentralityColvsMultiplicityRecoEta08' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:105:22: error: variable 'hRecoCentralityColvsMultiplicityFT0C' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:106:22: error: variable 'hRecoCentralityColvsImpactParamReco' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:107:22: error: variable 'hGenCentralityColvsMultiplicityGenEta05' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:108:22: error: variable 'hGenCentralityColvsMultiplicityGenEta08' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:109:22: error: variable 'hGenCentralityColvsMultiplicityFT0C' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:110:22: error: variable 'hGenCentralityColvsImpactParamGen' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:111:22: error: variable 'hGenLi4BeforeEvtSel' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:112:22: error: variable 'hGenLi4vsImpactParameterBeforeEvtSel' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:113:22: error: variable 'hGenLi4vsMultiplicityGenEta05BeforeEvtSel' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:114:22: error: variable 'hGenLi4vsMultiplicityGenEta08BeforeEvtSel' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:115:22: error: variable 'hGenLi4vsMultiplicityFT0CBeforeEvtSel' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:116:22: error: variable 'hGenLi4AfterSel' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:117:22: error: variable 'hGenLi4vsImpactParameterAfterSel' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:118:22: error: variable 'hGenLi4vsMultiplicityGenEta05AfterSel' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:119:22: error: variable 'hGenLi4vsMultiplicityGenEta08AfterSel' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:120:22: error: variable 'hGenLi4vsMultiplicityFT0CAfterSel' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:303:8: error: constructor does not initialize these fields: mCcdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:340:85: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:523:23: error: no header providing "TH3" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 6 -gt 0 ]]
++ cat /sw/BUILD/0eabc695084d3a5b9b6a4dbec868e3b1f1049b02/O2Physics-code-check/warnings.txt
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:678:14: warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:730:14: warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:782:7: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:1620:41: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:1622:53: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:1642:57: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 30 -gt 0 ]]
++ exit 1
--

[0 more errors; see full log]

Full log here.

@mpuccio
mpuccio merged commit 4e4e572 into AliceO2Group:master Aug 22, 2026
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants