[PWGJE] trackEfficiency: add track pT-eta-phi histogram; jetCrossSectionEfficiency review follow-up - #17539
Merged
Conversation
…Group#16546 * Restore <TH1.h> and <TH2.h>. They were dropped in AliceO2Group#16546 although the task uses registry.get<TH1>()/get<TH2>(); the build only survived because both arrive transitively through HistogramRegistry.h. The other removals (<algorithm>, <cstddef>, <set>, <utility>, <vector>) match symbols that are no longer used, and <cstdint> is needed for the fixed-width mask member. * Replace the magic-number bin indices of the two cascade variants by enums. They are unscoped, like the counter enums in the other PWGJE tasks, so the enumerators serve directly as bin numbers. Names spell out the variant they belong to (collRecoFirst, bcBitsFirst) and the event-selection flag each step checks. * Drop the redundant local copy of the eventSelections configurable and dispatch the preset through a single switch. * Rename the constexpr constants to UpperCamelCase, as required by the o2-linter rule name/constexpr-constant. Bin numbering, histogram labels and process-function logic are unchanged; the axis labels are identical before and after. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017xzpJe4BMMjS3m14A9w8V4
Adds a three-dimensional histogram of track pT, eta and phi to the track QA, so that the azimuthal distribution of the track sample can be inspected in pT slices. It is booked together with the other histograms of the track QA processes and filled in fillTrackHistograms, following the inline axis definitions used in that block. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017xzpJe4BMMjS3m14A9w8V4
joonsukbae
requested review from
alibuild,
fjonasALICE,
jaimenorman,
mhemmer-cern and
nzardosh
as code owners
August 21, 2026 11:49
|
O2 linter results: ❌ 1 errors, |
nzardosh
approved these changes
Aug 21, 2026
nzardosh
enabled auto-merge (squash)
August 21, 2026 12:10
Collaborator
|
Error while checking build/O2Physics/code-check for ddf0cb6 at 2026-08-21 14:33: Full log here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two independent changes:
trackEfficiency: adds a 3D histogram of track pT vs eta vs phi to the track QA processes, for azimuthal QA of the track sample in pT slices.jetCrossSectionEfficiency: addresses the review comments left on [PWGJE] jetCrossSectionEfficiency: cascade variants + hybrid-MC handling #16546 — restores<TH1.h>/<TH2.h>(used viaregistry.get<TH1/TH2>(), previously surviving only through transitive includes), replaces the magic-number bin indices by enums, drops the redundant local string copy and dispatches the event-selection preset through a singleswitch, and fixes the constexpr constant names pername/constexpr-constant. Bin numbering, histogram labels and process logic are unchanged.