[PWGDQ] fix match type assignment in ML training data producer - #17535
Merged
mcoquet642 merged 2 commits intoAug 22, 2026
Conversation
aferrero2707
requested review from
XiaozhiBai,
alibuild,
iarsene,
mcoquet642 and
mguilbau
as code owners
August 21, 2026 09:24
aferrero2707
marked this pull request as draft
August 21, 2026 09:24
|
O2 linter results: ❌ 1 errors, |
The match type assigned to candidate MFT-MCH matches in the ML training data producer task was wrongly set to "fake" in cases where the MCH track is pairable but the corresponding MFT track does not have an associated MC particle. In such cases the match type is now correctly assigned as "wrong".
aferrero2707
force-pushed
the
PWGDQ-matching-training-producer-fix-match-type-assignment
branch
from
August 21, 2026 09:25
13a912b to
5c29360
Compare
aferrero2707
force-pushed
the
PWGDQ-matching-training-producer-fix-match-type-assignment
branch
from
August 21, 2026 11:47
1789b38 to
d412958
Compare
Contributor
Author
|
@iarsene @mcoquet642 @XiaozhiBai @mguilbau this is a bug fix for the task that produces the ML training input data for the MFT-MCH matching. I have split the PR in two commits, the first with the actual bugfix and the second with the unrelated linter fixes. Could you please have a look? Thanks! |
aferrero2707
marked this pull request as ready for review
August 21, 2026 12:02
Collaborator
|
Error while checking build/O2Physics/code-check for d412958 at 2026-08-22 04:21: Full log here. |
Collaborator
mcoquet642
approved these changes
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The match type assigned to candidate MFT-MCH matches in the ML training data producer task was wrongly set to "fake" in cases where the MCH track is pairable but the corresponding MFT track does not have an associated MC particle. In such cases the match type is now correrctly assigned as " wrong".