Skip to content

[PWGCF] Efficiency Correction Added using CCDB Histograms - #17533

Open
rahulverma012 wants to merge 6 commits into
AliceO2Group:masterfrom
rahulverma012:kaonIsospinFluctuation2_EffCorrAdded
Open

[PWGCF] Efficiency Correction Added using CCDB Histograms#17533
rahulverma012 wants to merge 6 commits into
AliceO2Group:masterfrom
rahulverma012:kaonIsospinFluctuation2_EffCorrAdded

Conversation

@rahulverma012

@rahulverma012 rahulverma012 commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Code now contains parts related to efficiency correction implemented using the Histograms stored in CCDB.

Code now contains parts related to efficiency correction implement using the Histograms stored in CCDB
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 3 disabled

@github-actions github-actions Bot changed the title Efficiency Correction Added using CCDB Histograms [PWGCF] Efficiency Correction Added using CCDB Histograms Aug 21, 2026
@rahulverma012
rahulverma012 marked this pull request as draft August 21, 2026 02:21
Updated function signatures to use const references for string parameters and vector parameters.
@rahulverma012
rahulverma012 marked this pull request as ready for review August 21, 2026 04:02
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 6b682ec at 2026-08-21 08:23:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for ab1a41e at 2026-08-21 10:11:

No log files found

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for ab1a41e at 2026-08-21 12:16:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 74 errors and 216 warnings.'
Found 74 errors and 216 warnings.
++ [[ 74 -gt 0 ]]
++ cat /sw/BUILD/438ade37394846621a8ba967cd0075cac853d4b1/O2Physics-code-check/errors.txt
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:18:1: error: included header mcCentrality.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:39:1: error: included header O2DatabasePDGPlugin.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:43:1: error: included header LorentzVector.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:44:1: error: included header PxPyPzM4D.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:128:9: error: macro 'BIT_IS_K0S' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:129:9: error: macro 'BIT_IS_LAMBDA' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:130:9: error: macro 'BIT_IS_ANTILAMBDA' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:131:9: error: macro 'BIT_IS_GAMMA' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:132:9: error: macro 'BIT_IS_PHI_1020' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:133:9: error: macro 'BIT_IS_JPSI_TO_EE' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:134:9: error: macro 'BIT_IS_JPSI_TO_MUMU' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:135:9: error: macro 'BIT_IS_RHO_770' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:136:9: error: macro 'BIT_IS_KSTAR_892' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:137:9: error: macro 'BIT_IS_KSTAR_892_BAR' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:138:9: error: macro 'BIT_IS_LAMBDA_1520' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:139:9: error: macro 'BIT_IS_DELTA_1232' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:141:9: error: macro 'BIT_POS_DAU_HAS_SAME_COLL' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:142:9: error: macro 'BIT_NEG_DAU_HAS_SAME_COLL' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:143:9: error: macro 'BIT_BOTH_DAU_HAS_SAME_COLL' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:145:9: error: macro 'BIT_POS_DAU_HAS_SAME_COLL_BC' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:146:9: error: macro 'BIT_NEG_DAU_HAS_SAME_COLL_BC' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:147:9: error: macro 'BIT_BOTH_DAU_HAS_SAME_COLL_BC' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:149:9: error: function-like macro 'BITSET' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:150:9: error: function-like macro 'BITCHECK' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:151:9: error: function-like macro 'OTHERBITS' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:153:9: error: function-like macro 'BOOL_BITCHECK' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:154:9: error: function-like macro 'BOOL_OTHERBITSON' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:243:16: error: no header providing "o2::framework::LabeledArray" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:383:15: error: no header providing "RecoDecay" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:460:33: error: no header providing "Form" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:476:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:689:5: error: no header providing "size_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:932:10: error: no header providing "std::stringstream" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:992:3: error: no header providing "TH2F" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:1014:26: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:1026:40: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:1421:18: error: no header providing "std::ostringstream" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:1440:93: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:1444:93: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:1685:9: error: variable 'iPidMode' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:1686:9: error: variable 'signType' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:1687:9: error: variable 'variableType' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants