Conversation
8 tasks
Copilot
AI
changed the title
[WIP] Add SQL-99 compliance for trigger functionality
Harden DELETE/UPDATE trigger edge cases and expand test coverage
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CREATE TRIGGER CALL already passed row data for basic INSERT/UPDATE/DELETE cases, but DELETE ignored prevent/INSTEAD OF outcomes and AFTER UPDATE passed the new row twice.
Changes
table.delete() === falsefor BEFORE prevent and INSTEAD OF so matching rows stay in the table and skip AFTER DELETE / OUTPUTfalsefromtable.deleteso callers treat it like a prevented delete(oldRow, newRow)to triggerstest/test1119.jsfor AFTER UPDATE, prevent-delete, and INSTEAD OF DELETE