Fix contextual keyword parsing #327
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| SELECT DATE '2024-01-01', TIMESTAMP '2024-01-01 00:00:00', date AS timestamp; | ||
| SELECT * EXCEPT (a) FROM t; | ||
| SELECT 1 EXCEPT SELECT 2; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| -- Origin SQL: | ||
| SELECT DATE '2024-01-01', TIMESTAMP '2024-01-01 00:00:00', date AS timestamp; | ||
| SELECT * EXCEPT (a) FROM t; | ||
| SELECT 1 EXCEPT SELECT 2; | ||
|
|
||
|
|
||
| -- Beautify SQL: | ||
| SELECT | ||
| '2024-01-01', | ||
| '2024-01-01 00:00:00', | ||
| date AS timestamp; | ||
| SELECT | ||
| * EXCEPT(a) | ||
| FROM | ||
| t; | ||
| SELECT | ||
| 1 | ||
| EXCEPT | ||
| SELECT | ||
| 2; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| -- Origin SQL: | ||
| SELECT DATE '2024-01-01', TIMESTAMP '2024-01-01 00:00:00', date AS timestamp; | ||
| SELECT * EXCEPT (a) FROM t; | ||
| SELECT 1 EXCEPT SELECT 2; | ||
|
|
||
|
|
||
| -- Format SQL: | ||
| SELECT '2024-01-01', '2024-01-01 00:00:00', date AS timestamp; | ||
| SELECT * EXCEPT(a) FROM t; | ||
| SELECT 1 EXCEPT SELECT 2; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,220 @@ | ||
| [ | ||
| { | ||
| "SelectPos": 0, | ||
| "StatementEnd": 76, | ||
| "With": null, | ||
| "Top": null, | ||
| "HasDistinct": false, | ||
| "DistinctOn": null, | ||
| "SelectItems": [ | ||
| { | ||
| "Expr": { | ||
| "LiteralPos": 7, | ||
| "LiteralEnd": 23, | ||
| "Literal": "2024-01-01" | ||
| }, | ||
| "Modifiers": [], | ||
| "Alias": null | ||
| }, | ||
| { | ||
| "Expr": { | ||
| "LiteralPos": 26, | ||
| "LiteralEnd": 56, | ||
| "Literal": "2024-01-01 00:00:00" | ||
| }, | ||
| "Modifiers": [], | ||
| "Alias": null | ||
| }, | ||
| { | ||
| "Expr": { | ||
| "Name": "date", | ||
| "QuoteType": 1, | ||
| "NamePos": 59, | ||
| "NameEnd": 63 | ||
| }, | ||
| "Modifiers": [], | ||
| "Alias": { | ||
| "Name": "timestamp", | ||
| "QuoteType": 1, | ||
| "NamePos": 67, | ||
| "NameEnd": 76 | ||
| } | ||
| } | ||
| ], | ||
| "From": null, | ||
| "Window": null, | ||
| "Prewhere": null, | ||
| "Where": null, | ||
| "GroupBy": null, | ||
| "WithTotal": false, | ||
| "Having": null, | ||
| "OrderBy": null, | ||
| "LimitBy": null, | ||
| "Limit": null, | ||
| "Settings": null, | ||
| "Format": null, | ||
| "UnionAll": null, | ||
| "UnionDistinct": null, | ||
| "Except": null, | ||
| "Intersect": null | ||
| }, | ||
| { | ||
| "SelectPos": 78, | ||
| "StatementEnd": 104, | ||
| "With": null, | ||
| "Top": null, | ||
| "HasDistinct": false, | ||
| "DistinctOn": null, | ||
| "SelectItems": [ | ||
| { | ||
| "Expr": { | ||
| "Name": "*", | ||
| "QuoteType": 0, | ||
| "NamePos": 85, | ||
| "NameEnd": 85 | ||
| }, | ||
| "Modifiers": [ | ||
| { | ||
| "Name": { | ||
| "Name": "EXCEPT", | ||
| "QuoteType": 1, | ||
| "NamePos": 87, | ||
| "NameEnd": 93 | ||
| }, | ||
| "Params": { | ||
| "LeftParenPos": 94, | ||
| "RightParenPos": 96, | ||
| "Items": { | ||
| "ListPos": 95, | ||
| "ListEnd": 96, | ||
| "HasDistinct": false, | ||
| "Items": [ | ||
| { | ||
| "Expr": { | ||
| "Name": "a", | ||
| "QuoteType": 1, | ||
| "NamePos": 95, | ||
| "NameEnd": 96 | ||
| }, | ||
| "Alias": null | ||
| } | ||
| ] | ||
| }, | ||
| "ColumnArgList": null | ||
| } | ||
| } | ||
| ], | ||
| "Alias": null | ||
| } | ||
| ], | ||
| "From": { | ||
| "FromPos": 98, | ||
| "Expr": { | ||
| "Table": { | ||
| "TablePos": 103, | ||
| "TableEnd": 104, | ||
| "Alias": null, | ||
| "Expr": { | ||
| "Database": null, | ||
| "Table": { | ||
| "Name": "t", | ||
| "QuoteType": 1, | ||
| "NamePos": 103, | ||
| "NameEnd": 104 | ||
| } | ||
| }, | ||
| "HasFinal": false | ||
| }, | ||
| "StatementEnd": 104, | ||
| "SampleRatio": null, | ||
| "HasFinal": false | ||
| } | ||
| }, | ||
| "Window": null, | ||
| "Prewhere": null, | ||
| "Where": null, | ||
| "GroupBy": null, | ||
| "WithTotal": false, | ||
| "Having": null, | ||
| "OrderBy": null, | ||
| "LimitBy": null, | ||
| "Limit": null, | ||
| "Settings": null, | ||
| "Format": null, | ||
| "UnionAll": null, | ||
| "UnionDistinct": null, | ||
| "Except": null, | ||
| "Intersect": null | ||
| }, | ||
| { | ||
| "SelectPos": 106, | ||
| "StatementEnd": 114, | ||
| "With": null, | ||
| "Top": null, | ||
| "HasDistinct": false, | ||
| "DistinctOn": null, | ||
| "SelectItems": [ | ||
| { | ||
| "Expr": { | ||
| "NumPos": 113, | ||
| "NumEnd": 114, | ||
| "Literal": "1", | ||
| "Base": 10 | ||
| }, | ||
| "Modifiers": [], | ||
| "Alias": null | ||
| } | ||
| ], | ||
| "From": null, | ||
| "Window": null, | ||
| "Prewhere": null, | ||
| "Where": null, | ||
| "GroupBy": null, | ||
| "WithTotal": false, | ||
| "Having": null, | ||
| "OrderBy": null, | ||
| "LimitBy": null, | ||
| "Limit": null, | ||
| "Settings": null, | ||
| "Format": null, | ||
| "UnionAll": null, | ||
| "UnionDistinct": null, | ||
| "Except": { | ||
| "SelectPos": 122, | ||
| "StatementEnd": 130, | ||
| "With": null, | ||
| "Top": null, | ||
| "HasDistinct": false, | ||
| "DistinctOn": null, | ||
| "SelectItems": [ | ||
| { | ||
| "Expr": { | ||
| "NumPos": 129, | ||
| "NumEnd": 130, | ||
| "Literal": "2", | ||
| "Base": 10 | ||
| }, | ||
| "Modifiers": [], | ||
| "Alias": null | ||
| } | ||
| ], | ||
| "From": null, | ||
| "Window": null, | ||
| "Prewhere": null, | ||
| "Where": null, | ||
| "GroupBy": null, | ||
| "WithTotal": false, | ||
| "Having": null, | ||
| "OrderBy": null, | ||
| "LimitBy": null, | ||
| "Limit": null, | ||
| "Settings": null, | ||
| "Format": null, | ||
| "UnionAll": null, | ||
| "UnionDistinct": null, | ||
| "Except": null, | ||
| "Intersect": null | ||
| }, | ||
| "Intersect": null | ||
| } | ||
| ] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a caller parses and formats a typed literal such as
SELECT DATE '2024-01-01', this returns a plainStringLiteralafter consuming the type keyword, so formatting producesSELECT '2024-01-01'(as the new golden file demonstrates). That changes the expression from a typed Date/Timestamp literal into a String and can alter comparisons, overload resolution, and result schemas; the AST must retain and re-emit the consumed literal type.Useful? React with 👍 / 👎.