Skip to content

fix: admob issues - #2800

Merged
deadlyjack merged 2 commits into
mainfrom
fix/admob-issue
Aug 24, 2026
Merged

fix: admob issues#2800
deadlyjack merged 2 commits into
mainfrom
fix/admob-issue

Conversation

@deadlyjack

Copy link
Copy Markdown
Member

No description provided.

@greptile-apps

greptile-apps Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR improves AdMob consent handling, privacy-choice feedback, and banner recovery behavior while coordinating interstitial loading with extension installation.

  • Deduplicates concurrent privacy-option requests and safely handles unavailable native privacy UI.
  • Adds banner load listeners, bounded retry behavior, and lifecycle cleanup.
  • Loads interstitial ads alongside extension installation and displays them after completion.
  • Adds focused tests for consent concurrency and banner retry/state transitions.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
src/lib/adConsentCoordinator.mjs Deduplicates concurrent privacy-option requests while preserving consent and ad-start state.
src/lib/bannerVisibilityController.mjs Adds bounded banner retries, event-driven state updates, and listener/timer cleanup.
src/plugins/admob/src/android/cordova/Privacy.kt Avoids opening unnecessary privacy forms and rejects requests when the Android activity is unavailable.
src/sidebarApps/extensions/index.js Loads interstitial inventory concurrently with extension installation and shows it after the install workflow.
tests/admob/adConsentCoordinator.test.js Covers concurrent privacy requests and state preservation after native rejection.
tests/admob/bannerVisibilityController.test.js Covers retry limits, retry reset, navigation, disposal, banner replacement, and stale operations.

Reviews (2): Last reviewed commit: "fix: restore Android build commands" | Re-trigger Greptile

Comment thread utils/scripts/android.sh Outdated
@deadlyjack

Copy link
Copy Markdown
Member Author

@greptileai review again

@deadlyjack
deadlyjack added this pull request to the merge queue Aug 24, 2026
Merged via the queue into main with commit 9c3e869 Aug 24, 2026
11 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in The Code Board - Acode Aug 24, 2026
@deadlyjack
deadlyjack deleted the fix/admob-issue branch August 24, 2026 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant