fix(quick-tools): prevent scrollbars during editor gestures - #2777
Merged
Conversation
Contributor
Greptile SummaryThe PR replaces temporary CSS hit-test disabling with a short-lived capture-phase event guard, preventing older Android WebViews from repainting quick-tools scrollbars during editor gestures.
Confidence Score: 5/5The PR appears safe to merge with no concrete blocking or non-blocking defects identified. The new guard preserves the prior temporary blocking behavior while avoiding CSS hit-test toggling, and the repository’s event wiring and module-resolution configuration support the changed implementation. Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant EditorHandler
participant Guard
participant QuickTools
User->>EditorHandler: pointerdown in editor
EditorHandler->>Guard: markActive()
User->>QuickTools: event within 200 ms
QuickTools->>Guard: capture-phase suppress(event)
Guard-->>QuickTools: prevent default and stop propagation
Note over Guard,QuickTools: Events after expiry proceed normally
Reviews (1): Last reviewed commit: "fix(quick-tools): prevent scrollbars dur..." | Re-trigger Greptile |
This comment has been minimized.
This comment has been minimized.
This was referenced Aug 20, 2026
|
Preview Release for this, has been built. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #2338