FIX: Prefetch Lite hash asset used by integration tests - #153
Merged
Conversation
The integration tests clone ip-intelligence-java-examples and run its fetch-assets, which needs 51Degrees-LiteV4.1.hash. That asset was not in this repo's list, so it was missing from the prefetched cache and every matrix job downloaded the ~28MB LFS object itself. Listing it here fetches it once per run.
oleksandrlazarenko-pi
marked this pull request as ready for review
August 20, 2026 14:29
oleksandrlazarenko-pi
requested review from
justadreamer and
pi-alexander-popel
August 20, 2026 14:29
pi-alexander-popel
approved these changes
Aug 20, 2026
Contributor
|
I don't think it will help much since the file is downloaded straight from the CDN, not via LFS. But it won't hurt either, so approved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to 51Degrees/common-ci#221. The prefetch step runs this repo's ci/fetch-assets.ps1, which listed only the two .ipi assets, but the integration tests clone ip-intelligence-java-examples and run its fetch-assets, which also needs 51Degrees-LiteV4.1.hash. That left the ~28MB LFS object out of the asset cache, so all 14 matrix jobs downloaded it simultaneously and GitHub reset the connection (run 32327632917). Adding it to the prefetch list downloads it once per nightly run. Pairs with the retry fix in common-ci.