fix(typescript): pass SSE headers through requestInit - #674
Open
ZIFeIYUuuuuuu wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the remaining TypeScript
ssecompatibility path for #640.MCPToolProvidernow passes configured SSE headers throughrequestInit, which is the option shape consumed by the MCP SDK for both the SSE GET stream and the POST request. This keeps the legacy TypeScript path consistent with the already-correct v2 path and prevents authentication headers from being silently ignored.Problem
For a TypeScript server configuration such as:
the v1 compatibility branch constructed
SSEClientTransportwith{ headers: ... }at the top level.SSEClientTransportOptionsdoes not read that property; custom headers were therefore absent from the actual SSE requests and authenticated servers could not connect. The same configuration with no headers also passed an unnecessary{ headers: {} }object.Changes
requestInit: { headers }for configured SSE headers in the shared TypeScript path.undefinedwhen no headers are configured, preserving the SDK defaults.Validation
npm test -- --runInBand tests/mcpToolProvider.test.ts: 35 passed.npx eslint src/tools/mcpToolProvider.ts tests/mcpToolProvider.test.ts: passed.npx tsc --noEmit: passed.git diff --check: passed.tests/storage/ChatStorage.test.ts(an order assertion unrelated to MCP transport options).No API shape outside the TypeScript SSE transport construction is changed. The existing streamable-http and stdio paths remain unchanged.