Skip to content

funding service: simplify worker loop - #2663

Merged
Mirko-von-Leipzig merged 11 commits into
fs/4-account-top-up-v2from
codex/pr-2615-fixes
Sep 23, 2026
Merged

Mirko-von-Leipzig merged 11 commits into
fs/4-account-top-up-v2from
codex/pr-2615-fixes

Conversation

@Mirko-von-Leipzig

@Mirko-von-Leipzig Mirko-von-Leipzig commented Sep 21, 2026

Copy link
Copy Markdown
Collaborator

Simplifies the funding service to one sequential worker with at most one transaction in flight. Each transaction can consume one deposit and create queued funding notes.

  • Discover historical deposits at startup and filter spent notes using SyncNullifiers.
  • Continue discovering new deposits through SyncNotes.
  • Monitor commitment or expiration through SyncTransactions, including after uncertain transport failures.
  • Discard only the selected deposit on state-conflict rejection (error byte 2), preserving funding requests for retry.

Adds protobuf response validation and behavioral tests for discovery and transaction outcomes.

Changelog

changelog = "none"
reason    = "Internal change only."

Comment thread bin/funding-service/src/deposit.rs Outdated
Comment thread bin/funding-service/src/worker.rs Outdated
@Mirko-von-Leipzig
Mirko-von-Leipzig added this pull request to stack #2616 September 22, 2026 09:12

@kkovaacs kkovaacs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Mirko-von-Leipzig
Mirko-von-Leipzig merged commit 2dda14f into next Sep 23, 2026
30 checks passed
@Mirko-von-Leipzig
Mirko-von-Leipzig deleted the codex/pr-2615-fixes branch September 23, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants