feat(note-transport): add nonce to FetchNotes cursor - #2640
Merged
Merged
Conversation
kkovaacs
requested review from
Mirko-von-Leipzig,
WiktorStarczewski and
igamigo
September 17, 2026 11:36
kkovaacs
force-pushed
the
krisztian/note-transport-add-cursor-nonce
branch
from
September 17, 2026 12:04
5efe58d to
a9a30dd
Compare
kkovaacs
marked this pull request as ready for review
September 17, 2026 12:05
kkovaacs
force-pushed
the
krisztian/note-transport-add-cursor-nonce
branch
2 times, most recently
from
September 18, 2026 05:42
bd268b8 to
bb3d853
Compare
kkovaacs
force-pushed
the
krisztian/note-transport-add-cursor-nonce
branch
from
September 18, 2026 06:33
bb3d853 to
97a48aa
Compare
Mirko-von-Leipzig
added this pull request to stack #2661
September 21, 2026 10:26
Mirko-von-Leipzig
approved these changes
Sep 21, 2026
kkovaacs
force-pushed
the
krisztian/note-transport-add-cursor-nonce
branch
3 times, most recently
from
September 22, 2026 08:19
2332a3d to
5088be5
Compare
An error occurred while trying to automatically change base from
krisztian/note-transport-import
to
next
September 22, 2026 11:25
kkovaacs
force-pushed
the
krisztian/note-transport-add-cursor-nonce
branch
2 times, most recently
from
September 22, 2026 12:02
5a73ccb to
6f4e142
Compare
kkovaacs
removed this pull request from stack #2661
September 22, 2026 12:09
kkovaacs
changed the base branch from
krisztian/note-transport-import
to
next
September 22, 2026 12:09
kkovaacs
added this pull request to stack #2673
September 22, 2026 12:09
kkovaacs
force-pushed
the
krisztian/note-transport-add-cursor-nonce
branch
from
September 22, 2026 12:39
6f4e142 to
b6dc210
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace scalar cursors with a
fixed64nonce and sequence. Persist the nonce across restarts and returnFAILED_PRECONDITIONfor cursors from a replaced database. Includes migration, regression tests, and updated documentation.This is a solution to the issue where after a catastrophic event (eg. losing the note transport databse) clients get stuck receiving new notes because they're using invalid cursors. For a more detailed description please check 0xMiden/note-transport-service#97.
Changelog