refactor(ntx-builder): replace the account actors with a scheduler - #2585
Open
SantiagoPittella wants to merge 3 commits into
Open
SantiagoPittella wants to merge 3 commits into
SantiagoPittella wants to merge 3 commits into
Conversation
SantiagoPittella
force-pushed
the
santiagopittella-ntx-scheduler-swap
branch
from
September 7, 2026 14:18
c33fb3c to
ccbc958
Compare
SantiagoPittella
force-pushed
the
santiagopittella-ntx-scheduler-swap
branch
from
September 8, 2026 13:33
ccbc958 to
831b6f9
Compare
SantiagoPittella
force-pushed
the
santiagopittella-ntx-scheduler-swap
branch
from
September 9, 2026 21:00
831b6f9 to
c5b29a1
Compare
Collaborator
There was a problem hiding this comment.
I'm not a fan of attempt as a base name.
Perhaps something like NetworkTransactionContext and the current free standing functions could be methods?
Comment on lines
+294
to
+298
| pub async fn shutdown(&mut self) { | ||
| self.tasks.shutdown().await; | ||
| self.running.clear(); | ||
| self.in_flight.clear(); | ||
| } |
Collaborator
There was a problem hiding this comment.
When is this called? I'm surprised this isn't shutdown(self), then no need to keep this re-useable afterwards.
Collaborator
Author
There was a problem hiding this comment.
tokio;'s shutdown is also &mut so we just propagate it. This is called when a shutdown signal arrives
Comment on lines
+181
to
+192
| loop { | ||
| match self.tasks.join_next_with_id().await { | ||
| Some(Ok((id, outcome))) => { | ||
| self.running.remove(&id); | ||
| return Ok(outcome); | ||
| }, | ||
| Some(Err(err)) => { | ||
| let account_id = self.running.remove(&err.id()); | ||
| // Cancelled tasks were aborted on shutdown. | ||
| if err.is_cancelled() { | ||
| continue; | ||
| } |
Collaborator
There was a problem hiding this comment.
This loop and cancellation check feel a bit weird?
Collaborator
Author
There was a problem hiding this comment.
Replaced it with a match
Comment on lines
+263
to
+264
| // Applied before the failures so a note that is both corrected and penalized keeps the | ||
| // backoff block the penalty computes, which is the later of the two. |
Collaborator
There was a problem hiding this comment.
I don't quite understand why notes need to be corrected?
Collaborator
Author
There was a problem hiding this comment.
The wording sucks, but it is for sponsorship notes that writes the block the sponsorship arrived at, whatever the note's hint says, so it can mismatch and needs correction
SantiagoPittella
force-pushed
the
santiagopittella-ntx-scheduler-swap
branch
from
September 10, 2026 16:47
c5b29a1 to
14c5a4e
Compare
SantiagoPittella
force-pushed
the
santiagopittella-ntx-scheduler-swap
branch
from
September 11, 2026 21:27
14c5a4e to
d5adee5
Compare
SantiagoPittella
force-pushed
the
santiagopittella-ntx-scheduler-swap
branch
2 times, most recently
from
September 17, 2026 14:30
0fd2ad8 to
3ddd510
Compare
SantiagoPittella
force-pushed
the
santiagopittella-ntx-scheduler-swap
branch
2 times, most recently
from
September 21, 2026 12:11
f72d84a to
3d3fa0c
Compare
SantiagoPittella
force-pushed
the
santiagopittella-ntx-scheduler-swap
branch
from
September 21, 2026 20:22
3d3fa0c to
36fc7db
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Now the loop spawns a task per account, up to
--max-concurrent-txsat a time. The task picks notes, executes, proves, submits, and returns what happened, also this loops does the writting.The scheduler doesn't hold anything in memory per account except which transactions it has submitted and not yet seen committed.
Changelog