From 4c7bcc6a0a8f414ee650f3b0cd0734af69326bb5 Mon Sep 17 00:00:00 2001 From: 0xrlawrence Date: Mon, 31 Aug 2026 17:11:39 +0800 Subject: [PATCH] chore: correct UNLOCK_BLOCK_TIME comment and drop a dead assignment The comment above UNLOCK_BLOCK_TIME describes 100 blocks at 12 seconds, which is 1200 seconds, but the constant is 3600. Describe what the value is for instead of restating a number that does not match it. In ProcessOperatorSignedTaskResponseV2, taskIndex was initialized to zero and then immediately reassigned by the GetTaskIndexRetryable call on the following statement, so the initial value was never read. Co-Authored-By: Claude Opus 5 --- aggregator/pkg/server.go | 2 -- contracts/src/core/BatcherPaymentService.sol | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/aggregator/pkg/server.go b/aggregator/pkg/server.go index f28fc1ef62..1a75888fa3 100644 --- a/aggregator/pkg/server.go +++ b/aggregator/pkg/server.go @@ -60,8 +60,6 @@ func (agg *Aggregator) ProcessOperatorSignedTaskResponseV2(signedTaskResponse *t return errors.New("invalid response: nil signature") } - taskIndex := uint32(0) - // The Aggregator may receive the Task Identifier after the operators. // If that's the case, we won't know about the task at this point // so we make GetTaskIndex retryable, waiting for some seconds, diff --git a/contracts/src/core/BatcherPaymentService.sol b/contracts/src/core/BatcherPaymentService.sol index 379dd03796..0df8eceb09 100644 --- a/contracts/src/core/BatcherPaymentService.sol +++ b/contracts/src/core/BatcherPaymentService.sol @@ -14,7 +14,7 @@ contract BatcherPaymentService is UUPSUpgradeable, BatcherPaymentServiceStorage { - // CONSTANTS = 100 Blocks * 12 second block time. + // Delay a user must wait between calling unlock() and being able to withdraw. uint256 public constant UNLOCK_BLOCK_TIME = 3600 seconds; // EVENTS