Skip to content

Path normalization can fail on windows #140

Description

@samhill303

Before you start

  • I searched the existing issues (including closed ones) and didn't find this one.
  • I'm using a currently released version of this project.

Summary

The fixSlashes function doesn't account for a mix of / and \ which may be valid for a path on windows. This appears to not generally cause an issue beyond failing tests, but there are likely edge cases to check

Steps to reproduce

Run windows tests without ignoring path tests

Expected result

All valid paths should be correctly handled, and tests should match the behavior

Actual result

Tests are failing

Affected platforms

  • Android
  • iOS
  • macOS
  • watchOS / tvOS
  • JVM
  • JS / Wasm
  • Linux / Windows (native)
  • Not platform specific
  • Build / Gradle plugin only

Version

1.4.0

Environment

No response

Logs, stack traces, or build output


Possible cause or fix

We could consider moving our path concatenation and slash fixing logic over to kotlin.io's path class

Screenshots or anything else

No response

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions