Skip to content

isAuctionExpired view function is with wrong return value #643

Description

@karacurt

The actual function is considering active auctions as expired (if endTimestamp is in the future)

  function isAuctionExpired(uint256 _auctionId) external view onlyExistingAuction(_auctionId) returns (bool) {
        return _englishAuctionsStorage().auctions[_auctionId].endTimestamp >= block.timestamp;
    } 

The correct conditional should be to check if endTimestamp is in the past, and then return true for expired.

I opened a PR with the fix here

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions