From 2d70d3e30e1a6fd303e4b6abe8e1862f3ddd684c Mon Sep 17 00:00:00 2001 From: Hassan Kibirige Date: Mon, 21 Sep 2026 18:18:48 +0300 Subject: [PATCH] fix: declare the docs extra's actual dependencies The `docs` optional-dependency group only listed plotnine, so the docs workflow installed jupyter, polars, pandas, pyarrow, great-tables, mcp, and marimo by hand instead of through `pip install -e ".[docs]"`. Add those packages to `docs`, keep the great-tables pin below 0.22 that the marimo notebooks' WASM export needs, and have `mcp`, `marimo`, `docs`, and `dev` reference each other instead of repeating the same dependencies across groups. --- .github/workflows/docs.yml | 3 +-- pyproject.toml | 14 +++++++++----- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml index 7c4ae3ec..c0e018db 100644 --- a/.github/workflows/docs.yml +++ b/.github/workflows/docs.yml @@ -22,8 +22,7 @@ jobs: - name: Install dependencies run: | python -m pip install --upgrade pip - python -m pip install -e ".[mcp,marimo]" - python -m pip install jupyter polars pandas pyarrow plotnine 'great-tables<0.22' + python -m pip install -e ".[docs]" - name: Set up Quarto uses: quarto-dev/quarto-actions/setup@v2 diff --git a/pyproject.toml b/pyproject.toml index 59bed43f..d873d8bb 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -67,15 +67,19 @@ dev = [ "pyright>=1.1.407", "build>=0.7", "twine>=3.4", - "great_tables>=0.21.0", - "pandas>=2.0", - "polars>=0.20", - "pyarrow>=12.0", - "mcp>=1.0.0", "typer>=0.12.0", + "great-docs[docs]", ] docs = [ "plotnine>=0.13.0", + "jupyter>=1.0.0", + "polars>=0.20", + "pandas>=2.0", + "pyarrow>=12.0", + # Pin below 0.22: that release depends on multimark, a compiled package + # with no WASM wheel, which breaks the marimo notebooks' Pyodide export. + "great_tables>=0.21.0,<0.22", + "great-docs[mcp,marimo]", ]