From 20f8e66ae8016a832ff92932c1338c00327510d5 Mon Sep 17 00:00:00 2001 From: Brandon Corbett Date: Thu, 3 Sep 2026 19:28:50 -0400 Subject: [PATCH] fix(verify): follow the React SDK past its passkey naming step @seamless-auth/react used to open a "Name This Device" modal after "Register Passkey" was pressed, and registerWithPasskey typed into it before the WebAuthn ceremony would start. That view is gone from the SDK, so the helper waited 30 seconds for a placeholder that no longer renders and then timed out, failing react/passkeyRegister.spec.ts and react/passkeyLogin.spec.ts (which registers before it signs back in). The helper now stops at the button, which is where the ceremony begins. This tracks the SDK release that drops the modal. A --local run against an older React checkout, or a published run before that release lands on npm, will fail on the modal this no longer dismisses. --- .changeset/verify-passkey-naming-step.md | 15 +++++++++++++++ verify/harness/lib/reactFlows.ts | 2 -- 2 files changed, 15 insertions(+), 2 deletions(-) create mode 100644 .changeset/verify-passkey-naming-step.md diff --git a/.changeset/verify-passkey-naming-step.md b/.changeset/verify-passkey-naming-step.md new file mode 100644 index 0000000..bc452ba --- /dev/null +++ b/.changeset/verify-passkey-naming-step.md @@ -0,0 +1,15 @@ +--- +'seamless-cli': patch +--- + +Follow the React SDK's passkey enrollment through the removal of its naming step. + +`@seamless-auth/react` used to open a "Name This Device" modal after "Register Passkey" was +pressed, and the harness typed into it before the WebAuthn ceremony would start. That view is +gone from the SDK, so `registerWithPasskey` waited 30 seconds for a placeholder that no longer +renders and then timed out, failing `react/passkeyRegister.spec.ts` and `react/passkeyLogin.spec.ts` +(which registers before it signs back in). + +The helper now stops at the button, which is where the ceremony begins. This tracks the SDK +release that drops the modal, so a `--local` run against an older React checkout, or a published +run before that release lands on npm, will fail on the modal this no longer dismisses. diff --git a/verify/harness/lib/reactFlows.ts b/verify/harness/lib/reactFlows.ts index 7feb3c8..eeb58a5 100644 --- a/verify/harness/lib/reactFlows.ts +++ b/verify/harness/lib/reactFlows.ts @@ -90,8 +90,6 @@ export async function registerWithPasskey(page: Page, email: string): Promise