From 0f2d4dc0bf0aab33b9629f8aec036ba4becc9dfa Mon Sep 17 00:00:00 2001 From: Marketen Date: Mon, 24 Aug 2026 10:32:55 +0200 Subject: [PATCH] Revert the dappnodesdk 0.3.52 pin: it does not fix the first publish The pinned run failed identically with ResolverNotFound. Both 0.3.52 and 0.3.53 declare @dappnode/toolkit ^0.1.21, and the toolkit declares ethers ^6.9.0, so a fresh install resolves a current ethers whatever the dappnodesdk version is, and that raises ResolverNotFound rather than NOREPO. The earlier local test suggesting otherwise was invalid: it used a globally installed copy whose dependency tree was frozen at install time. The fix belongs in DAppNodeSDK and is proposed in dappnode/DAppNodeSDK#480. This package can publish once a release carrying it is on npm. Co-Authored-By: Claude Opus 5 --- .github/workflows/main.yml | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index a649d94..4ec6e06 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -14,9 +14,7 @@ jobs: name: Build test steps: - uses: actions/checkout@v4 - # Pinned: 0.3.53 cannot publish a package that is not yet registered - # on-chain. See the Publish step below. - - run: npx @dappnode/dappnodesdk@0.3.52 build --skip_save + - run: npx @dappnode/dappnodesdk build --skip_save env: # Read access to the private dappnode-nexus-sdk repository. The # default GITHUB_TOKEN is scoped to this repository only and cannot @@ -30,13 +28,7 @@ jobs: steps: - uses: actions/checkout@v4 - name: Publish - # Pinned to 0.3.52. In 0.3.53 the "package not yet registered on-chain" - # case is detected by matching the old ethers error text "NOREPO", but - # current ethers raises ResolverNotFound instead, so the guard misses and - # the publish aborts. 0.3.52 still reports NOREPO, falls back to the - # manifest version, and emits the release with its manual publish link. - # Unpin once DAppNodeSDK handles ResolverNotFound. - run: npx @dappnode/dappnodesdk@0.3.52 publish patch --dappnode_team_preset --timeout 2h + run: npx @dappnode/dappnodesdk publish patch --dappnode_team_preset --timeout 2h env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} NEXUS_SDK_TOKEN: ${{ secrets.NEXUS_SDK_TOKEN }}