From 58cb89e96e6dd994215289598bb4b4a5a1cd81f1 Mon Sep 17 00:00:00 2001 From: Edwin Gonzales Date: Mon, 21 Sep 2026 13:32:58 +0800 Subject: [PATCH 1/2] test(spp_drims): assert SLA coverage over the canonical priority codes only test_sla_hours_are_keyed_by_real_priority_codes compared against every code in the vocabulary, so installing an overlay that legitimately extends priorities (spp_drims_sl adds life_threatening, ADR-016) made the exact-match assertion fail on a fourth key spp_drims never claimed to cover. Its sibling test already used _canonical_codes_in for the same reason (#438). Refs #443 --- spp_drims/__manifest__.py | 2 +- spp_drims/readme/HISTORY.md | 4 ++++ spp_drims/tests/test_constants.py | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/spp_drims/__manifest__.py b/spp_drims/__manifest__.py index d5064f9d..16cb8a6a 100644 --- a/spp_drims/__manifest__.py +++ b/spp_drims/__manifest__.py @@ -5,7 +5,7 @@ "and distribution tracking. Links to hazard incidents with multi-tier " "approval workflows and warehouse operations.", "category": "OpenSPP/Inventory", - "version": "19.0.4.0.4", + "version": "19.0.4.0.5", "sequence": 1, "author": "OpenSPP.org", "website": "https://github.com/OpenSPP/OpenSPP2", diff --git a/spp_drims/readme/HISTORY.md b/spp_drims/readme/HISTORY.md index 0cc26bee..6e6648c4 100644 --- a/spp_drims/readme/HISTORY.md +++ b/spp_drims/readme/HISTORY.md @@ -1,3 +1,7 @@ +### 19.0.4.0.5 + +- fix(tests): the SLA completeness test now checks only the priority codes spp_drims itself ships. It compared against every code in the vocabulary, so installing an overlay that legitimately extends priorities — spp_drims_sl adds life_threatening — made the exact-match assertion fail on a fourth key the module never claimed to cover + ### 19.0.4.0.4 - fix(drims): name constants after codes the vocabulary actually ships, and fix the three places that used the wrong ones. An urgent request answered a 24-hour approval SLA instead of 8 hours, the priority badge and list decorations never fired, and the High Priority search filter always returned nothing — all because the code asked for priorities the data does not contain. A test now walks every code constant against its vocabulary, so one naming a code that does not exist fails the build instead of silently matching nothing (#1165) diff --git a/spp_drims/tests/test_constants.py b/spp_drims/tests/test_constants.py index 81ba77a9..7e9f5429 100644 --- a/spp_drims/tests/test_constants.py +++ b/spp_drims/tests/test_constants.py @@ -192,7 +192,7 @@ def test_sla_hours_are_keyed_by_real_priority_codes(self): whole failure mode OP#1165 is about. """ settings = self.env["res.config.settings"] - codes = self._codes_in(constants.VOCAB_PRIORITY_LEVELS) + codes = self._canonical_codes_in(constants.VOCAB_PRIORITY_LEVELS) hours = {code: settings.get_approval_sla_hours(code) for code in codes} self.assertEqual( From 9424f4df125b18f63561da679d1ef0a02596ad2f Mon Sep 17 00:00:00 2001 From: Edwin Gonzales Date: Mon, 21 Sep 2026 13:46:52 +0800 Subject: [PATCH 2/2] docs(spp_drims): regenerate README from fragments (CI output) --- spp_drims/README.rst | 9 ++++++++ spp_drims/static/description/index.html | 28 +++++++++++++++++-------- 2 files changed, 28 insertions(+), 9 deletions(-) diff --git a/spp_drims/README.rst b/spp_drims/README.rst index 575f410e..999cef49 100644 --- a/spp_drims/README.rst +++ b/spp_drims/README.rst @@ -179,6 +179,15 @@ Dependencies Changelog ========= +19.0.4.0.5 +~~~~~~~~~~ + +- fix(tests): the SLA completeness test now checks only the priority + codes spp_drims itself ships. It compared against every code in the + vocabulary, so installing an overlay that legitimately extends + priorities — spp_drims_sl adds life_threatening — made the exact-match + assertion fail on a fourth key the module never claimed to cover + 19.0.4.0.4 ~~~~~~~~~~ diff --git a/spp_drims/static/description/index.html b/spp_drims/static/description/index.html index 89704662..46819672 100644 --- a/spp_drims/static/description/index.html +++ b/spp_drims/static/description/index.html @@ -565,6 +565,16 @@

Changelog

+

19.0.4.0.5

+
    +
  • fix(tests): the SLA completeness test now checks only the priority +codes spp_drims itself ships. It compared against every code in the +vocabulary, so installing an overlay that legitimately extends +priorities — spp_drims_sl adds life_threatening — made the exact-match +assertion fail on a fourth key the module never claimed to cover
    • +
+
+

19.0.4.0.4

  • fix(drims): name constants after codes the vocabulary actually ships, @@ -577,7 +587,7 @@

    19.0.4.0.4

    the build instead of silently matching nothing (#1165)
-
+

19.0.4.0.3

  • fix(drims): show only the states a dispatch can reach on its status @@ -587,7 +597,7 @@

    19.0.4.0.3

    shows when a dispatch is actually in it (#1086)
-
+

19.0.4.0.2

  • feat(drims): confirm a delivery through a popup rather than the @@ -597,7 +607,7 @@

    19.0.4.0.2

    reflects what was received rather than what was sent (#1088)
-
+

19.0.4.0.1

  • fix(drims): only let a dispatch ship what its request approved. @@ -607,7 +617,7 @@

    19.0.4.0.1

    and delete affordances hidden to match (#1057)
-
+

19.0.4.0.0

  • feat(drims): Donations review — creation, receipt, inspection and @@ -627,7 +637,7 @@

    19.0.4.0.0

    but no longer readable through the ORM or shown in any view (#1076)
-
+

19.0.3.1.0

  • feat(drims): Incident Management review — incidents are entered as a @@ -644,7 +654,7 @@

    19.0.3.1.0

    refresh cron skips (#1100)
-
+

19.0.3.0.4

  • feat(drims): rework the dispatch page and correct the waybill. @@ -664,7 +674,7 @@

    19.0.3.0.4

    barcode (#1151)
-
+

19.0.3.0.1

  • fix(drims): a dispatch validated short no longer leaves the request @@ -676,7 +686,7 @@

    19.0.3.0.1

    API (#1087)
-
+

19.0.3.0.0

  • feat(drims): allocate stock per source warehouse. The Allocate Stock @@ -696,7 +706,7 @@

    19.0.3.0.0

    destination-type selector (#1075)
-
+

19.0.2.0.0

  • Initial migration to OpenSPP2