Skip to content

animartrix: new fixed effect IDs lead to effects being dropped (IDs already used by ParticleFX) #271

Description

@softhack007

strip.addEffect(203, &mode_Module_Experiment10, _data_FX_mode_Module_Experiment10);

The new "fixed reliable effect IDs" used in the animartix usermod are not working as expected.

  • IDs > MODE_COUNT = 228 will be allocated to an arbitrary free slot
  • IDs that clash with ParticleFX will lead to effects being dropped silently.

Below is some debug output from my new 16bit effectID branch

addEffect(203) -> addEffect(114) => Y💡Module_Experiment10 ☾@Speed;;1;2
addEffect(204) -> addEffect(142) => Y💡Module_Experiment9 ☾@Speed;;1;2
addEffect(205) -> addEffect(151) => Y💡Module_Experiment8 ☾@Speed;;1;2
addEffect(206) -> addEffect(161) => Y💡Module_Experiment7 ☾@Speed;;1;2
addEffect(207) -> addEffect(169) => Y💡Module_Experiment6 ☾@Speed;;1;2
addEffect(208) -> addEffect(170) => Y💡Module_Experiment5 ☾@Speed;;1;2
addEffect(209) -> addEffect(171) => Y💡Module_Experiment4 ☾@Speed;;1;2
addEffect(210) -> addEffect(187) => Y💡Zoom2 ☾@Speed;;1;2
addEffect(211) -> addEffect(189) => Y💡Module_Experiment3 ☾@Speed;;1;2
addEffect(212) -> addEffect(193) => Y💡Module_Experiment2 ☾@Speed;;1;2
addEffect(213) -> addEffect(228) => Y💡Module_Experiment1 ☾@Speed;;1;2
addEffect(214) -> addEffect(229) => Y💡Parametric_Water ☾@Speed;;1;2
addEffect(215) -> addEffect(230) => Y💡Water ☾@Speed;;1;2
addEffect(216) -> addEffect(231) => Y💡Complex_Kaleido_6 ☾@Speed;;1;2
addEffect(217) -> addEffect(232) => Y💡Complex_Kaleido_5 ☾@Speed;;1;2
addEffect(218) -> addEffect(233) => Y💡Complex_Kaleido_4 ☾@Speed;;1;2
addEffect(219) -> addEffect(234) => Y💡Complex_Kaleido_3 ☾@Speed;;1;2
addEffect(220) -> addEffect(235) => Y💡Complex_Kaleido_2 ☾@Speed;;1;2
addEffect(221) -> addEffect(236) => Y💡Complex_Kaleido ☾@Speed;;1;2
addEffect(222) -> addEffect(237) => Y💡SM10 ☾@Speed;;1;2
addEffect(223) -> addEffect(238) => Y💡SM9 ☾@Speed;;1;2
addEffect(224) -> addEffect(239) => Y💡SM8 ☾@Speed;;1;2
addEffect(226) -> addEffect(240) => Y💡SM6 ☾@Speed;;1;2
addEffect(227) -> addEffect(241) => Y💡SM5 ☾@Speed;;1;2
addEffect(228) -> addEffect(242) => Y💡SM4 ☾@Speed;;1;2
addEffect(229) -> addEffect(243) => Y💡SM3 ☾@Speed;;1;2
addEffect(230) -> addEffect(244) => Y💡SM2 ☾@Speed;;1;2
addEffect(231) -> addEffect(245) => Y💡SM1 ☾@Speed;;1;2
addEffect(232) -> addEffect(246) => Y💡Big_Caleido ☾@Speed;;1;2
addEffect(233) -> addEffect(247) => Y💡RGB_Blobs5 ☾@Speed;;1;2
addEffect(234) -> addEffect(248) => Y💡RGB_Blobs4 ☾@Speed;;1;2
addEffect(235) -> addEffect(249) => Y💡RGB_Blobs3 ☾@Speed;;1;2
addEffect(236) -> addEffect(250) => Y💡RGB_Blobs2 ☾@Speed;;1;2
addEffect(237) -> addEffect(251) => Y💡RGB_Blobs ☾@Speed;;1;2
addEffect(238) -> addEffect(252) => Y💡Polar_Waves ☾@Speed;;1;2
addEffect(239) -> addEffect(253) => Y💡Slow_Fade ☾@Speed;;1;2
addEffect(240) -> addEffect(254) => Y💡Zoom ☾@Speed;;1;2
addEffect(241) -> addEffect(256) => Y💡Hot_Blob ☾@Speed;;1;2
addEffect(242) -> addEffect(257) => Y💡Spiralus2 ☾@Speed;;1;2
addEffect(243) -> addEffect(258) => Y💡Spiralus ☾@Speed;;1;2
addEffect(244) -> addEffect(259) => Y💡Yves ☾@Speed;;1;2
addEffect(245) -> addEffect(260) => Y💡Scaledemo1 ☾@Speed;;1;2
addEffect(246) -> addEffect(261) => Y💡Lava1 ☾@Speed;;1;2
addEffect(247) -> addEffect(262) => Y💡Caleido3 ☾@Speed;;1;2
addEffect(248) -> addEffect(263) => Y💡Caleido2 ☾@Speed;;1;2
addEffect(249) -> addEffect(264) => Y💡Caleido1 ☾@Speed;;1;2
addEffect(250) -> addEffect(265) => Y💡Distance_Experiment ☾@Speed;;1;2
addEffect(251) -> addEffect(266) => Y💡Center_Field ☾@Speed;;1;2
addEffect(252) -> addEffect(267) => Y💡Waves ☾@Speed;;1;2
addEffect(253) -> addEffect(268) => Y💡Chasing_Spirals ☾@Speed;;1;2
addEffect(254) -> addEffect(269) => Y💡Rotating_Blob ☾@Speed;;1;2

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions