Skip to content

syn2 and syn3 are mutually exclusive #28

Description

@datdenkikniet

Hi,

It seems that the syn2 and syn3 features are mutually exclusive, as they both a copy of the following impl:

impl<T: quote::ToTokens> ManyhowToTokens<T> for &WhatType<T> {}

additionally, the following two blanket impls collide when both features are activated:

#[cfg(all(feature = "syn2", not(doc)))]
impl<T: syn2::parse::Parse> ManyhowParse<T> for &WhatType<T> {}

#[cfg(feature = "syn3")]
impl<T: syn3::parse::Parse> ManyhowParse<T> for &WhatType<T> {}

Is this intended? This suggests that using this crate in a setup that has both syn2 and syn3 based proc-macros that use the same version manyhow will never compile since (AFAIK) the features for manyhow will be unified.

Thanks,

Jona

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions