The digit `1` is differend width than other characters

[bombsimon]

The digit 1 is different width from other characters, primarily noticeable when running the stopwatch and showing tenths. Every time a 1 is displayed, the whole text shifts a few pixels since it's less total width.

All characters in the font should have the same width. This might also potentially fix the ( padding hack used for line 11 in departures and might be a good fix before #25

[matrixbox]

The reason for this was that some numbers look weird when 1 is one of the digits.

For example, the number 11, if having the same width as other numbers, has a lot of empty space. The "(" solution was used for padding alignment instead.

To check it out, change "1" so that it has the same width as other numbers, remove the padding, and look at the line-id numbers and time-left/clock in /departures

[bombsimon]

Yeah I got that it was for padding, but I think we can align the digit so it matches and still have it render normal like fonts usually do.

The proposed fix isn't to just push padding to the side but rather center it so 1px to the left and 1px to the right.

Like this (click to expand)

diff --git a/lib/font_large.py b/lib/font_large.py
index 98c7591..5e13209 100644
--- a/lib/font_large.py
+++ b/lib/font_large.py
@@ -854,21 +854,21 @@ font_large = {
     0b0000000
   ],
   "1": [
-    5,
-    0b00110,
-    0b01110,
-    0b11110,
-    0b00110,
-    0b00110,
-    0b00110,
-    0b00110,
-    0b00110,
-    0b00110,
-    0b00110,
-    0b00000,
-    0b00000,
-    0b00000,
-    0b00000
+    7,
+    0b0001100,
+    0b0011100,
+    0b0111100,
+    0b0001100,
+    0b0001100,
+    0b0001100,
+    0b0001100,
+    0b0001100,
+    0b0001100,
+    0b0001100,
+    0b0000000,
+    0b0000000,
+    0b0000000,
+    0b0000000
   ],
   "2": [
     7,
diff --git a/lib/font_mini.py b/lib/font_mini.py
index d7dcc63..f3b602c 100644
--- a/lib/font_mini.py
+++ b/lib/font_mini.py
@@ -1006,12 +1006,12 @@ font_mini = {
     0b000,
   ],
   "1": [
-    2,
-    0b0010,
-    0b0010,
-    0b0010,
-    0b0010,
-    0b0010,
+    4,
+    0b0100,
+    0b0100,
+    0b0100,
+    0b0100,
+    0b0100,
     0b0000,
   ],
   "2": [

Simulator output

I don't think it looks that much different from the padded one and still better than the current non padded one. Note also as a bonus the text next to it (the station lines) gets aligned correctly since all characters (0-9) share the same width. Also note that this is a bit inconsistent since font small is the same width as the rest so with padding it pushes it to the right. I assume apps like departures doesn't notice this since it computes the width of the text to be written and allocate space for thatn.

Current without padding (11)

Current with padding (1(1)

Proposed fix (11)

To me this looks perfectly normal

[bombsimon]

I pushed and opened #36 if you want to try the proposal out on real hardware as well.

[matrixbox]

The proposed fix looks much better than current🔥

[bombsimon]

Do you want to test this some more or want me to take photos of real hardware before merging?

[matrixbox]

No, go ahead and merge, I'm sure it's fine!